Fix unix socket path for MacOS on Apple Silicon. #3375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datho7561
requested changes
Nov 7, 2023
There was a problem hiding this comment.
I think it might be a good idea to update the CONTRIBUTING documentation (I don't know if this is the right doc) to specify that Node 18 is required, and specify what version of npm is required (I think the npm version is any 9.y.z). The format of package-lock.json changed significantly twice between npm 6 and npm 9, so if you npm i using the wrong version of npm it will fail or rewrite the file.
Otherwise, the code looks good! Unfortunately don't have access to Apple Silicon to test.
|
Good catch. Yeah we definitely need to update the contributing document to indicate the Node version required. |
testforstephen
approved these changes
Nov 8, 2023
Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
- vscode-jsonrpc now reacts to IPC path limits on platforms - Update vscode-languageclient from 8.1.0 to 8.2.0-next.3 - Use vscode-jsonrpc 8.2.1-next.1 - Requires engine bump from 1.67 -> 1.79 Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a pre-requisite to using the "overrides" entry (which requires npm 8.x), I've updated to Node 18. Let me know if that looks ok.
Fixes #3371 & eclipse-jdtls/eclipse.jdt.ls#2932
See microsoft/vscode-languageserver-node#1346
Fix is at microsoft/vscode-languageserver-node@d01d3ed