Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change scope of 'java.import.gradle.home' to machine-overridable #3430

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Change scope of 'java.import.gradle.home' to machine-overridable #3430

merged 1 commit into from
Dec 15, 2023

Conversation

hopehadfield
Copy link
Contributor

As requested in #3234. A similar change was made for java.import.gradle.java.home, and I see no issues in this case.

@rgrunber rgrunber added this to the End December 2023 milestone Dec 14, 2023
rgrunber
rgrunber approved these changes Dec 15, 2023
View reviewed changes
Copy link
Member

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me.

@rgrunber
Copy link
Member

@hopehadfield I would add the setting to restrictedConfiguration. We don't validate the gradle home location on the language server side, only if the project uses a Gradle wrapper.

@hopehadfield
Change scope of 'java.import.gradle.home' to machine-overridable
d64d4f1 
Signed-off-by: Hope Hadfield <hhadfiel@redhat.com>
@rgrunber rgrunber merged commit 1cb8d0c into redhat-developer:master Dec 15, 2023
2 checks passed
@rgrunber rgrunber linked an issue Dec 15, 2023 that may be closed by this pull request
Change the scope of java.import.gradle.home to machine-overridable #3234
Closed
@hopehadfield hopehadfield deleted the 3234-scope branch April 23, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgrunber rgrunber rgrunber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Early January 2024
Development

Successfully merging this pull request may close these issues.

Change the scope of java.import.gradle.home to machine-overridable
2 participants
@hopehadfield @rgrunber