Multi root adoption #347
Closed
Multi root adoption #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aeschli can you sign-off your last commit please? |
fbricon
reviewed
Oct 31, 2017
| @@ -58,15 +58,17 @@ | |||
| "null" | |||
There was a problem hiding this comment.
should we add the multi-root ready keyword as recommended or is it too early?
aeschli
force-pushed
the
multi-root-adoption
branch
from
2747629
to
82f07d2
Compare
|
Not sure why this doesn't work. |
Signed-off-by: Martin Aeschlimann <martinae@microsoft.com>
aeschli
force-pushed
the
multi-root-adoption
branch
from
82f07d2
to
77f9775
Compare
|
ok, all commits need to be signed (in eclipse.jdt.ls it just has to be the last). |
|
@gorkem ^^ |
|
rebased as 5a0ef76 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.