Provide mechanism to disable buildship #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbricon
reviewed
Dec 13, 2017
package.json
Outdated
| @@ -111,6 +111,12 @@ | |||
| "description": "Traces the communication between VS Code and the Java language server.", | |||
| "scope": "window" | |||
| }, | |||
| "java.skip.gradleImporter": { | |||
There was a problem hiding this comment.
To be consistent with the existing java.import.exclusions preference and others toggle like prefs, we should have java.import.gradle.enabled
snjeza
force-pushed
the
issue-257
branch
2 times, most recently
from
3260dff
to
59c9429
Compare
fbricon
reviewed
Dec 13, 2017
package.json
Outdated
| "java.import.maven.enabled": { | ||
| "type": "boolean", | ||
| "default": true, | ||
| "description": "Enable/disable the maven importer.", |
fbricon
reviewed
Dec 13, 2017
package.json
Outdated
| "java.import.gradle.enabled": { | ||
| "type": "boolean", | ||
| "default": true, | ||
| "description": "Enable/disable the gradle importer.", |
fbricon
requested changes
Dec 13, 2017
Signed-off-by: Snjezana Peco <snjezana.peco@redhat.com>
|
@fbricon I have updated the PR. |
fbricon
approved these changes
Dec 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes eclipse-jdtls/eclipse.jdt.ls#257
Requires eclipse-jdtls/eclipse.jdt.ls#497
Signed-off-by: Snjezana Peco snjezana.peco@redhat.com