add step to publish to static when... #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbricon
reviewed
Jun 6, 2018
Jenkinsfile
Outdated
| }//if publishMarketPlace | ||
| }// if publishToMarketPlace | ||
|
|
||
| if(publishToStable.equals('true')){ |
There was a problem hiding this comment.
We don't need a new publishToStable parameter. This block should be executed if package was successufully pushed to the marketplace
There was a problem hiding this comment.
yes, that was just for my own testing. Here's the cleaned up / squashed PR. a1da5e3
externalize tools@ to Jenkins param Signed-off-by: nickboldt <nboldt@redhat.com>
nickboldt
force-pushed
the
snapshot-publish
branch
from
57dd0b1
to
a1da5e3
Compare
|
Note that UPLOAD_LOCATION has already been added as a param on https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/view/Adapters/view/VSCode/job/vscode-java_release/configure so once merged this should Just Work (tm). |
|
Thanks for the patch @nickboldt! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add step to publish to static when publishing to Marketplace; remove unneeded code (?) too
Change-Id: Iae731a81524bf8e416c0af67170b7378977efd47
Signed-off-by: nickboldt nboldt@redhat.com