-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose import projects command #746
Conversation
Just an idea come up in my mind: how about prompt users to import if we detect the workspace contains valid project? Take an example of the C# extension, when user opens a C# project folder, it will pop up a dialog to ask user if he want's to add required assets for build/debug: We can do the same thing, the Java Language Server can run in syntax mode by default, if it detects there is any build configuration files, then asks user to import it as a Java project. We can benefit from this experience by:
|
|
It doesn't work: If I have a multimodule Maven project, add a new module under the parent project, import doesn't find anything |
The succession of merge commits is just a huge mess. |
Signed-off-by: Sheng Chen <sheche@microsoft.com>
@fbricon The commits are rebased, could you please try again? I tried both multi-module Maven/Gradle, both can detect new sub-module and generate |
@fbricon If still not working, is it possible to share the project to let me diagnostic? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The import command should activate vscode-java
package.json
Outdated
@@ -553,6 +553,11 @@ | |||
"title": "Update project configuration", | |||
"category": "Java" | |||
}, | |||
{ | |||
"command": "java.project.import", | |||
"title": "Import Java projects in workspacce", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
workspace
Signed-off-by: Sheng Chen <sheche@microsoft.com>
I keep calling the import new project command, now the server is started, but still see the "No delegateCommandHandler for java.project.import" error |
Sorry, looks like a PEBCAK. I didn't rebuild the proper server branch |
See eclipse-jdtls/eclipse.jdt.ls#144
Requires eclipse-jdtls/eclipse.jdt.ls#901
Signed-off-by: Snjezana Peco snjezana.peco@redhat.com