API that is returning Disposable should be added to subscriptions extension's context #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…they're disposed during the stop lifecycle of the plug-in. handle it for registerCommand and workspace.registerTextDocumentContentProvider and window.onDidChangeActiveTextEditor Change-Id: I10e3f0b96337e69c91d0d98590722f1f4364e4aa Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf
force-pushed
the
handle-subscriptions
branch
from
c970301
to
13b3204
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so they're disposed during the stop lifecycle of the plug-in. (and avoid duplicate handlers/ commands for example when restarting it)
handle it for