Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display property expression evaluation as inlay hint #108

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

angelozerr
Copy link
Contributor

Display property expression evaluation as inlay hint

See eclipse/lsp4mp#226

Signed-off-by: azerr azerr@redhat.com

See eclipse/lsp4mp#226

Signed-off-by: azerr <azerr@redhat.com>
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't get it to work in Theia, but that's for reasons completely unrelated to this change. It works great in VS Code, so I think it's okay to merge this.

@angelozerr angelozerr marked this pull request as ready for review August 30, 2022 05:47
@angelozerr angelozerr merged commit 1f90f0b into redhat-developer:master Aug 30, 2022
@angelozerr
Copy link
Contributor Author

Thanks @datho7561 for your review.

@rgrunber rgrunber added this to the 0.6.0 milestone Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants