Disable odo telemetry using env variable when running through extensi…

…on (#2131) Signed-off-by: Denis Golovin dgolovin@redhat.com
redhat-developer · May 11, 2021 · 7470ff4 · 7470ff4
1 parent 583d506
commit 7470ff4
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 11 deletions.
diff --git a/config/preference.yaml b/config/preference.yaml
diff --git a/src/odo.ts b/src/odo.ts
@@ -761,16 +761,22 @@ export class OdoImpl implements Odo {
         return services;
     }
 
+    public createEnv(): {} {
+        const env = {...process.env };
+        env.ODO_DISABLE_TELEMETRY = 'true';
+        return env;
+    }
+
     public async executeInTerminal(command: CommandText, cwd: string = process.cwd(), name = 'OpenShift'): Promise<void> {
         const [cmd] = `${command}`.split(' ');
         const toolLocation = await ToolsConfig.detect(cmd);
-        const terminal: Terminal = WindowUtil.createTerminal(name, cwd);
+        const terminal: Terminal = WindowUtil.createTerminal(name, cwd, this.createEnv());
         terminal.sendText(toolLocation === cmd ? `${command}` : `${command}`.replace(cmd, `"${toolLocation}"`), true);
         terminal.show();
     }
 
     public async execute(command: CommandText, cwd?: string, fail = true, addEnv = {}): Promise<cliInstance.CliExitData> {
-        const env = {...process.env };
+        const env = this.createEnv();
         const commandActual = `${command}`;
         const commandPrivacy = `${command.privacyMode(true)}`;
         const [cmd] = commandActual.split(' ');

diff --git a/test/unit/odo.test.ts b/test/unit/odo.test.ts
@@ -89,7 +89,7 @@ suite('odo', () => {
             const cwd = 'path/to/some/dir';
             await odoCli.execute(command, cwd);
 
-            expect(execStub).calledOnceWith(`${command}`, { cwd, env: process.env });
+            expect(execStub).calledOnceWith(`${command}`, { cwd, env: (odo.getInstance() as odo.OdoImpl).createEnv() });
         });
 
         test('execute rejects if an error occurs in the shell command', async () => {