Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

knative icon will be shown on the terminal for serverless call #3628

Conversation

msivasubramaniaan
Copy link
Collaborator

icon-change

As per @mohitsuman suggestion the terminal icon would be knative if it is a serverless function call and the title should be in camel case.

Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (0d6dfaa) 33.41% compared to head (f322797) 33.39%.
Report is 2 commits behind head on main.

Files Patch % Lines
...rc/webview/openshift-terminal/openShiftTerminal.ts 0.00% 4 Missing ⚠️
src/serverlessFunction/functions.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3628      +/-   ##
==========================================
- Coverage   33.41%   33.39%   -0.03%     
==========================================
  Files          84       84              
  Lines        6096     6100       +4     
  Branches     1239     1239              
==========================================
  Hits         2037     2037              
- Misses       4059     4063       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mohitsuman
Copy link
Collaborator

Fixes #3637

Copy link
Collaborator

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working well. Thanks, Muthu!

@datho7561 datho7561 merged commit 49dcfaf into redhat-developer:main Nov 28, 2023
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terminal icon would be knative if it is a serverless function call and the title should be in camel case.
3 participants