Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl+clicking a link in the OpenShift Terminal should open the URL #3543 #3641

Conversation

vrubezhny
Copy link
Contributor

Fixes: #3543

@vrubezhny vrubezhny force-pushed the fix-enable-openshift-terminal-open-links branch from 9fdf97a to 05e02c8 Compare November 28, 2023 15:26
Copy link
Collaborator

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working well for me. Thanks, Victor!

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (e096ae4) 33.41% compared to head (05e02c8) 33.38%.
Report is 1 commits behind head on main.

Files Patch % Lines
...rc/webview/openshift-terminal/openShiftTerminal.ts 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3641      +/-   ##
==========================================
- Coverage   33.41%   33.38%   -0.04%     
==========================================
  Files          84       84              
  Lines        6096     6102       +6     
  Branches     1239     1243       +4     
==========================================
  Hits         2037     2037              
- Misses       4059     4065       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vrubezhny vrubezhny merged commit 3604a72 into redhat-developer:main Nov 28, 2023
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ctrl+clicking a link in the OpenShift Terminal should open the URL
2 participants