Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error popup when expanding project in Application Explorer #3520 #3644

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Error popup when expanding project in Application Explorer #3520 #3644

merged 1 commit into from
Nov 29, 2023

Conversation

vrubezhny
Copy link
Contributor

Fixes: #3520

@vrubezhny vrubezhny marked this pull request as draft November 28, 2023 20:50
@codecov Codecov
Copy link

codecov bot commented Nov 28, 2023 •
edited

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (643b3c2) 33.36% compared to head (56d57a2) 33.31%.
Report is 1 commits behind head on main.

❗ Current head 56d57a2 differs from pull request most recent head cf2ae97. Consider uploading reports for the commit cf2ae97 to get more accurate results

Files Patch % Lines
src/oc/ocWrapper.ts 0.00% 6 Missing ⚠️
src/explorer.ts 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3644      +/-   ##
==========================================
- Coverage   33.36%   33.31%   -0.05%     
==========================================
  Files          84       84              
  Lines        6106     6114       +8     
  Branches     1243     1245       +2     
==========================================
  Hits         2037     2037              
- Misses       4069     4077       +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vrubezhny vrubezhny force-pushed the fix-explorer-cannot-list-resource-error branch 2 times, most recently from c04ae76 to 56d57a2 Compare November 28, 2023 23:31
@vrubezhny vrubezhny force-pushed the fix-explorer-cannot-list-resource-error branch from 56d57a2 to cf2ae97 Compare November 29, 2023 01:00
@datho7561
Copy link
Collaborator

This seems to fix the issue now.

@vrubezhny vrubezhny marked this pull request as ready for review November 29, 2023 16:17
@datho7561 datho7561 merged commit b859e8d into redhat-developer:main Nov 29, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datho7561 datho7561 datho7561 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error popup when expanding project in Application Explorer
2 participants
@vrubezhny @datho7561