Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Service has empty dropdown on Sandbox #3544 #3704

Conversation

vrubezhny
Copy link
Contributor

Fixes: #3544

Fixes: redhat-developer#3544

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (5b58008) 33.25% compared to head (58dd547) 33.22%.

Files Patch % Lines
src/explorer.ts 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3704      +/-   ##
==========================================
- Coverage   33.25%   33.22%   -0.03%     
==========================================
  Files          84       84              
  Lines        6126     6131       +5     
  Branches     1252     1253       +1     
==========================================
  Hits         2037     2037              
- Misses       4089     4094       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks, Victor!

@datho7561 datho7561 merged commit 2df63cb into redhat-developer:main Dec 8, 2023
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Service has empty dropdown on Sandbox
2 participants