Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync repo before installation and close the model once installation success #3708

Conversation

msivasubramaniaan
Copy link
Collaborator

This PR sync the repository before installing the chart. Also close the model if installation was success

…uccess

Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
@msivasubramaniaan msivasubramaniaan added this to the 1.11.0 milestone Dec 8, 2023
@msivasubramaniaan msivasubramaniaan self-assigned this Dec 8, 2023
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (953df42) 33.23% compared to head (37a9f7f) 33.27%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3708      +/-   ##
==========================================
+ Coverage   33.23%   33.27%   +0.04%     
==========================================
  Files          84       84              
  Lines        6130     6131       +1     
  Branches     1252     1252              
==========================================
+ Hits         2037     2040       +3     
+ Misses       4093     4091       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! Sorry about the delay, took me a while to reproduce the issue where the charts aren't loaded.

@datho7561 datho7561 merged commit 189a3aa into redhat-developer:main Dec 8, 2023
6 checks passed
@msivasubramaniaan msivasubramaniaan deleted the close-model-after-installed branch December 10, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants