Open route URL in browser #3718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3718 +/- ##
==========================================
- Coverage 33.24% 33.21% -0.03%
==========================================
Files 84 84
Lines 6136 6156 +20
Branches 1253 1257 +4
==========================================
+ Hits 2040 2045 +5
- Misses 4096 4111 +15 ☔ View full report in Codecov by Sentry. |
datho7561
requested changes
Dec 11, 2023
vrubezhny
previously approved these changes
Dec 11, 2023
There was a problem hiding this comment.
Looks good to me if getRoute(project: string) function is inlined as @datho7561 suggested.
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
datho7561
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3652
open-route-url.mp4
Note: Currently hardcoded the route URL with
http