Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed CRC status indications and some UI improvements #3737

Conversation

msivasubramaniaan
Copy link
Collaborator

Fixes: #3723

@mohitsuman
Copy link
Collaborator

mohitsuman commented Dec 13, 2023

@msivasubramaniaan please add the new UI screenshot. A gif would be better to show the responsiveness of the UI.

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (233e74b) 33.24% compared to head (aa7cbe8) 33.20%.
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3737      +/-   ##
==========================================
- Coverage   33.24%   33.20%   -0.05%     
==========================================
  Files          84       84              
  Lines        6136     6159      +23     
  Branches     1253     1258       +5     
==========================================
+ Hits         2040     2045       +5     
- Misses       4096     4114      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msivasubramaniaan
Copy link
Collaborator Author

@msivasubramaniaan please add the new UI screenshot. A gif would be better to show the responsiveness of the UI.

FYR

crc-responsive.mp4

Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
@mohitsuman
Copy link
Collaborator

How does it look for Started CRC cluster ?

@msivasubramaniaan
Copy link
Collaborator Author

How does it look for Started CRC cluster ?

image
image

Copy link
Collaborator

@mohitsuman mohitsuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mohitsuman mohitsuman merged commit 238f7cb into redhat-developer:main Dec 13, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CRC OpenShift status showed as green even though it was stopped
2 participants