Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error processing in 'LoginUtils.requireLogin' #3782

Conversation

vrubezhny
Copy link
Contributor

Error mesage: Cannot read properties of null (reading 'toLowerCase')

Error mesage: Cannot read properties of null (reading 'toLowerCase')

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (caeada7) 33.12% compared to head (43995e6) 33.12%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/util/loginUtil.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3782   +/-   ##
=======================================
  Coverage   33.12%   33.12%           
=======================================
  Files          84       84           
  Lines        6195     6195           
  Branches     1270     1270           
=======================================
  Hits         2052     2052           
  Misses       4143     4143           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@datho7561 datho7561 self-requested a review January 8, 2024 15:12
@datho7561
Copy link
Collaborator

I don't know how to reproduce this issue, but "Login" seems to still work after the change

@vrubezhny
Copy link
Contributor Author

I don't know how to reproduce this issue, but "Login" seems to still work after the change

I was doing some context switching stuff on Friday, then left the app working through the weekend (putting my note to asleep and waking it up for a few times, thus loosing the connection to the cluster) so today I had to re-login to a cluster, but it looks like oc status wasn't available for some reason, so it's execution finished with an error not returning any result in stderr (its value was null). The PR fixes such a case.

@vrubezhny vrubezhny merged commit 96988da into redhat-developer:main Jan 8, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants