Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve switch context workflow #3804

Merged

Conversation

vrubezhny
Copy link
Contributor

No description provided.

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

Attention: 88 lines in your changes are missing coverage. Please review.

Comparison is base (993f710) 33.12% compared to head (49bd5e0) 32.80%.

Files Patch % Lines
src/openshift/cluster.ts 1.85% 53 Missing ⚠️
src/util/kubeUtils.ts 0.00% 29 Missing ⚠️
src/explorer.ts 20.00% 4 Missing ⚠️
src/util/loginUtil.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3804      +/-   ##
==========================================
- Coverage   33.12%   32.80%   -0.32%     
==========================================
  Files          84       84              
  Lines        6195     6255      +60     
  Branches     1270     1295      +25     
==========================================
  Hits         2052     2052              
- Misses       4143     4203      +60     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works very well! Thanks, Victor!

@datho7561 datho7561 added this to the 1.12.0 milestone Jan 15, 2024
@datho7561 datho7561 merged commit 41892e5 into redhat-developer:main Jan 15, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Context doesn't look switched when using the same cluster URL, but different project
2 participants