Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force refresh App explorer on create project... #3813

Conversation

vrubezhny
Copy link
Contributor

...when new project name is the same as the one set in the current-context.

The steps to reproduce:

  • On Openshift cluster: create a project giving it some name
  • assert that the project is successfully created, the App Explorer is refreshed automatically and the new project is lister in the App Explorer tree
  • Delete the project
  • Assert that the project is successfully deleted, the App Explorer is refreshed automatically and the deleted projectbow is marked as "Missing ptoject: in the App Explorer
  • Click on the "Missing project" tree item to "Create new or set Active project"
  • Chose "Create new project" and type exactly the same name as it was used to create the project tne the beginning
  • Assert that the project is successfully created
  • FAIL: Assert the App Explorer is refreshed automatically and tthe new project is listed in the App Explorer

...when new project name is the same as the one set in the current-context.

The steps to reproduce:
- On Openshift cluster: create a project giving it some name
- assert that the project is successfully created, the App Explorer is refreshed automatically and
  the new project is lister in the App Explorer tree
- Delete the project
- Assert that the project is successfully deleted, the App Explorer is refreshed automatically and
  the deleted projectbow is marked as "Missing ptoject: in the App Explorer
- Click on the "Missing project" tree item to "Create new or set Active project"
- Chose "Create new project" and type exactly the same name as it was used to create the project tne the beginning
- Assert that the project is successfully created
- FAIL: Assert the App Explorer is refreshed automatically and tthe new project is listed in the App Explorer

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (b0ed57a) 32.80% compared to head (1d48b3c) 32.79%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/openshift/project.ts 16.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3813      +/-   ##
==========================================
- Coverage   32.80%   32.79%   -0.02%     
==========================================
  Files          84       84              
  Lines        6255     6260       +5     
  Branches     1295     1296       +1     
==========================================
+ Hits         2052     2053       +1     
- Misses       4203     4207       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vrubezhny
Copy link
Contributor Author

The screen cast demonstrating the issue: #3591 (comment)

Copy link
Collaborator

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works great. Thanks, Victor!

@datho7561 datho7561 added this to the 1.12.0 milestone Jan 17, 2024
@datho7561 datho7561 merged commit d9c4592 into redhat-developer:main Jan 17, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants