Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open a Deployment in shell from Application Explorer #3827

Merged
merged 1 commit into from
Feb 10, 2024

Conversation

datho7561
Copy link
Collaborator

Right click on a Deployment in the Application Explorer and select "Open Shell to Container" to open a terminal connection to the running container in the 'OpenShift Terminal'.

Closes #3825

Signed-off-by: David Thompson davthomp@redhat.com

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (e9d3ead) 32.41% compared to head (e328aa3) 32.43%.

Files Patch % Lines
src/deployment.ts 60.00% 2 Missing ⚠️
src/explorer.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3827      +/-   ##
==========================================
+ Coverage   32.41%   32.43%   +0.02%     
==========================================
  Files          85       85              
  Lines        6396     6401       +5     
  Branches     1321     1321              
==========================================
+ Hits         2073     2076       +3     
- Misses       4323     4325       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Right click on a Deployment in the Application Explorer and select "Open
Shell to Container" to open a terminal connection to the running container
in the 'OpenShift Terminal'.

Closes redhat-developer#3825

Signed-off-by: David Thompson <davthomp@redhat.com>
@mohitsuman
Copy link
Collaborator

@datho7561 can you please share a working gif for this workflow ?

@datho7561
Copy link
Collaborator Author

shell-into-deployment.mp4

Copy link
Contributor

@vrubezhny vrubezhny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@mohitsuman mohitsuman merged commit 0b85593 into redhat-developer:main Feb 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Open a shell in a running Deployment
3 participants