Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin minor version of nodejs to use in cyclic dependency check #3829

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

datho7561
Copy link
Collaborator

Fixes #3828

Signed-off-by: David Thompson davthomp@redhat.com

Fixes redhat-developer#3828

Signed-off-by: David Thompson <davthomp@redhat.com>
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bc41991) 32.41% compared to head (57944e4) 32.41%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3829   +/-   ##
=======================================
  Coverage   32.41%   32.41%           
=======================================
  Files          85       85           
  Lines        6396     6396           
  Branches     1321     1321           
=======================================
  Hits         2073     2073           
  Misses       4323     4323           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@vrubezhny vrubezhny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Just a question: Is there any real problem related to Node minor version?

@datho7561
Copy link
Collaborator Author

No, the problem is that with the latest version of node 18, the npm version will be >=10, and we state that npm must be <10 in the package.json, so that check fails, causing the CI to fail.

@datho7561 datho7561 merged commit e9d3ead into redhat-developer:main Jan 19, 2024
6 checks passed
@datho7561 datho7561 deleted the 3828-fix-cycles-check branch January 19, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI failure due to new npm version
2 participants