Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add terminal view context on serverless function session #3843

Conversation

msivasubramaniaan
Copy link
Collaborator

Fixes: #3640

Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 80 lines in your changes are missing coverage. Please review.

Comparison is base (f94d3f6) 33.12% compared to head (dbecffc) 32.37%.
Report is 56 commits behind head on main.

Files Patch % Lines
src/serverlessFunction/view.ts 11.11% 32 Missing ⚠️
src/serverlessFunction/functions.ts 0.00% 22 Missing ⚠️
...ew/serverless-function/serverlessFunctionLoader.ts 25.00% 15 Missing ⚠️
...rc/webview/openshift-terminal/openShiftTerminal.ts 8.33% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3843      +/-   ##
==========================================
- Coverage   33.12%   32.37%   -0.75%     
==========================================
  Files          84       85       +1     
  Lines        6195     6505     +310     
  Branches     1270     1349      +79     
==========================================
+ Hits         2052     2106      +54     
- Misses       4143     4399     +256     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
@msivasubramaniaan msivasubramaniaan marked this pull request as ready for review January 29, 2024 18:11
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
@msivasubramaniaan
Copy link
Collaborator Author

Here is the demo for this PR:
serverless-session

Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Copy link
Collaborator

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks, Muthu!

@datho7561 datho7561 merged commit bb79639 into redhat-developer:main Jan 31, 2024
4 of 6 checks passed
@msivasubramaniaan msivasubramaniaan deleted the 3640-show-context-menu-to-open-in-terminal-for-the-function-created branch January 31, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show context menu to Open in Terminal for the function created
2 participants