Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Odo.getKubeconfigEnv() (it is not needed) #3874

Merged

Conversation

datho7561
Copy link
Collaborator

Closes #3664

Signed-off-by: David Thompson davthomp@redhat.com

Closes redhat-developer#3664

Signed-off-by: David Thompson <davthomp@redhat.com>
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (da60441) 32.37% compared to head (4457f44) 45.54%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3874       +/-   ##
===========================================
+ Coverage   32.37%   45.54%   +13.16%     
===========================================
  Files          85       85               
  Lines        6505     6493       -12     
  Branches     1349     1337       -12     
===========================================
+ Hits         2106     2957      +851     
+ Misses       4399     3536      -863     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@vrubezhny vrubezhny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@vrubezhny vrubezhny merged commit ea14ea8 into redhat-developer:main Feb 5, 2024
6 checks passed
@datho7561 datho7561 deleted the 3664-delete-getkubeconfigenv branch February 5, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete Odo.getKubeconfigEnv
2 participants