Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix require login check, use 'oc whoami' to check current cluster and user #3875

Conversation

vrubezhny
Copy link
Contributor

No description provided.

… user

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
@vrubezhny vrubezhny force-pushed the fix-require-login-check-to-use-oc-whoami branch from 75f7c39 to 673fcda Compare February 3, 2024 15:32
@vrubezhny vrubezhny changed the title Fix require login check, use `oc whoami' to check current cluster and user Fix require login check, use 'oc whoami' to check current cluster and user Feb 3, 2024
Copy link

codecov bot commented Feb 3, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (da60441) 32.37% compared to head (673fcda) 45.61%.
Report is 6 commits behind head on main.

Files Patch % Lines
src/util/loginUtil.ts 44.44% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3875       +/-   ##
===========================================
+ Coverage   32.37%   45.61%   +13.24%     
===========================================
  Files          85       85               
  Lines        6505     6511        +6     
  Branches     1349     1350        +1     
===========================================
+ Hits         2106     2970      +864     
+ Misses       4399     3541      -858     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works well for me. This addresses the issues I was running into with logging out. Thanks, Victor!

@datho7561 datho7561 merged commit 9556fd0 into redhat-developer:main Feb 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants