Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loading deployment confguration #3945

Conversation

msivasubramaniaan
Copy link
Collaborator

Fixes: #3928

Note: I have taken the code from https://github.com/vscode-kubernetes-tools/vscode-kubernetes-tools/blob/7e5c5f6082112314d189a4a88dc5173a8303a5e4/src/kuberesources.virtualfs.ts#L19 and added undefined check on our extension as there were no active development on vscode-kubernetes-tools. Moving forward we should plan to get rid of the vscode-kubernetes-tools dependency on our extension

Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 45.24%. Comparing base (da60441) to head (89282a9).
Report is 68 commits behind head on main.

Files Patch % Lines
src/explorer.ts 25.00% 21 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3945       +/-   ##
===========================================
+ Coverage   32.37%   45.24%   +12.87%     
===========================================
  Files          85       85               
  Lines        6505     6637      +132     
  Branches     1349     1377       +28     
===========================================
+ Hits         2106     3003      +897     
+ Misses       4399     3634      -765     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@datho7561
Copy link
Collaborator

Doesn't work for me, still broken on Linux.

@msivasubramaniaan
Copy link
Collaborator Author

Doesn't work for me, still broken on Linux.

I am not having Linux machine, I don't know how to test over it

@datho7561
Copy link
Collaborator

I'll try it again and provide the warnings it gives, hopefully that gives enough info to fix it. If not, I can look into it.

@datho7561
Copy link
Collaborator

This error notification I get. It seems identical to the one you described fixing.

Get command failed: error: unable to match a printer suitable for the output format "undefined", allowed formats are: custom-columns,custom-columns-file,go-template,go-template-file,json,jsonpath,jsonpath-as-json,jsonpath-file,name,template,templatefile,wide,yaml

I also get this error notification, which I expect is related:

Error loading document: CodeExpectedError: cannot open k8smsx://loadkubernetescore/deployment-my-pet-alpine?ns%3Ddefault%26value%3Ddeployment%2Fmy-pet-alpine%26_%3D1709053141730. Detail: Get command failed: error: unable to match a printer suitable for the output format "undefined", allowed formats are: custom-columns,custom-columns-file,go-template,go-template-file,json,jsonpath,jsonpath-as-json,jsonpath-file,name,template,templatefile,wide,yaml

Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
@msivasubramaniaan
Copy link
Collaborator Author

This error notification I get. It seems identical to the one you described fixing.

Get command failed: error: unable to match a printer suitable for the output format "undefined", allowed formats are: custom-columns,custom-columns-file,go-template,go-template-file,json,jsonpath,jsonpath-as-json,jsonpath-file,name,template,templatefile,wide,yaml

I also get this error notification, which I expect is related:

Error loading document: CodeExpectedError: cannot open k8smsx://loadkubernetescore/deployment-my-pet-alpine?ns%3Ddefault%26value%3Ddeployment%2Fmy-pet-alpine%26_%3D1709053141730. Detail: Get command failed: error: unable to match a printer suitable for the output format "undefined", allowed formats are: custom-columns,custom-columns-file,go-template,go-template-file,json,jsonpath,jsonpath-as-json,jsonpath-file,name,template,templatefile,wide,yaml

set vs-kubernetes.outputFormat as yaml default. @datho7561 please try it now

Copy link
Collaborator

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the issue for me! Thanks, Muthu!

@msivasubramaniaan msivasubramaniaan merged commit 2e18c59 into redhat-developer:main Feb 27, 2024
5 of 6 checks passed
@msivasubramaniaan msivasubramaniaan deleted the 3928-cant-load-helm-chart branch February 27, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't load Helm chart
2 participants