-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
loading deployment confguration #3945
loading deployment confguration #3945
Conversation
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3945 +/- ##
===========================================
+ Coverage 32.37% 45.24% +12.87%
===========================================
Files 85 85
Lines 6505 6637 +132
Branches 1349 1377 +28
===========================================
+ Hits 2106 3003 +897
+ Misses 4399 3634 -765 ☔ View full report in Codecov by Sentry. |
Doesn't work for me, still broken on Linux. |
I am not having Linux machine, I don't know how to test over it |
I'll try it again and provide the warnings it gives, hopefully that gives enough info to fix it. If not, I can look into it. |
This error notification I get. It seems identical to the one you described fixing.
I also get this error notification, which I expect is related:
|
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
set |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes the issue for me! Thanks, Muthu!
2e18c59
into
redhat-developer:main
Fixes: #3928
Note: I have taken the code from https://github.com/vscode-kubernetes-tools/vscode-kubernetes-tools/blob/7e5c5f6082112314d189a4a88dc5173a8303a5e4/src/kuberesources.virtualfs.ts#L19 and added undefined check on our extension as there were no active development on vscode-kubernetes-tools. Moving forward we should plan to get rid of the vscode-kubernetes-tools dependency on our extension