Cluster dependant suite fix #3960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lukas Grossmann <lgrossma@redhat.com>
Signed-off-by: Lukas Grossmann <lgrossma@redhat.com>
Signed-off-by: Lukas Grossmann <lgrossma@redhat.com>
Signed-off-by: Lukas Grossmann <lgrossma@redhat.com>
Signed-off-by: Lukas Grossmann <lgrossma@redhat.com>
Signed-off-by: Lukas Grossmann <lgrossma@redhat.com>
Signed-off-by: Lukas Grossmann <lgrossma@redhat.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3960 +/- ##
===========================================
+ Coverage 32.37% 45.24% +12.87%
===========================================
Files 85 85
Lines 6505 6637 +132
Branches 1349 1366 +17
===========================================
+ Hits 2106 3003 +897
+ Misses 4399 3634 -765 ☔ View full report in Codecov by Sentry. |
datho7561
approved these changes
Mar 5, 2024
lgrossma
added a commit
to lgrossma/vscode-openshift-tools
that referenced
this pull request
Mar 7, 2024
* Changing nodejs version for cluster-dependant test suite Signed-off-by: Lukas Grossmann <lgrossma@redhat.com> * Fixing before each and afterall methods Signed-off-by: Lukas Grossmann <lgrossma@redhat.com> * Fixing eslint error Signed-off-by: Lukas Grossmann <lgrossma@redhat.com> * fixing closing notifications in wrong method Signed-off-by: Lukas Grossmann <lgrossma@redhat.com> * adding import Signed-off-by: Lukas Grossmann <lgrossma@redhat.com> * fixing afterall Signed-off-by: Lukas Grossmann <lgrossma@redhat.com> * fixing afterall Signed-off-by: Lukas Grossmann <lgrossma@redhat.com> --------- Signed-off-by: Lukas Grossmann <lgrossma@redhat.com> Fixing before each and afterall methods Signed-off-by: Lukas Grossmann <lgrossma@redhat.com> Fixing eslint error Signed-off-by: Lukas Grossmann <lgrossma@redhat.com> fixing closing notifications in wrong method Signed-off-by: Lukas Grossmann <lgrossma@redhat.com> adding import Signed-off-by: Lukas Grossmann <lgrossma@redhat.com> fixing afterall Signed-off-by: Lukas Grossmann <lgrossma@redhat.com> fixing afterall Signed-off-by: Lukas Grossmann <lgrossma@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to stabilize the cluster dependant UI test suite #3057