Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use node 20 in CI build #3972

Merged
merged 2 commits into from
Mar 18, 2024
Merged

use node 20 in CI build #3972

merged 2 commits into from
Mar 18, 2024

Conversation

mohitsuman
Copy link
Collaborator

No description provided.

@datho7561
Copy link
Collaborator

Tests are working, although extester is only targetting Node 18 and VS Code should be using NodeJS 20.

Could you please update the node version in two other spots:

  • .nvmrc
  • package.json: the engines field on line 18

Copy link
Collaborator

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good. Thanks, Mohit!

@datho7561 datho7561 merged commit 65b1e4c into main Mar 18, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants