Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding project test #4012

Merged
merged 3 commits into from
Apr 3, 2024
Merged

adding project test #4012

merged 3 commits into from
Apr 3, 2024

Conversation

lgrossma
Copy link
Contributor

See: #3694, #3695

Signed-off-by: Lukas Grossmann <lgrossma@redhat.com>
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.01%. Comparing base (da60441) to head (16a330b).
Report is 126 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4012       +/-   ##
===========================================
+ Coverage   32.37%   45.01%   +12.64%     
===========================================
  Files          85       85               
  Lines        6505     6704      +199     
  Branches     1349     1385       +36     
===========================================
+ Hits         2106     3018      +912     
+ Misses       4399     3686      -713     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.01%. Comparing base (da60441) to head (82c7373).
Report is 147 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4012       +/-   ##
===========================================
+ Coverage   32.37%   45.01%   +12.63%     
===========================================
  Files          85       85               
  Lines        6505     6716      +211     
  Branches     1349     1403       +54     
===========================================
+ Hits         2106     3023      +917     
+ Misses       4399     3693      -706     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Lukas Grossmann <lgrossma@redhat.com>
@datho7561
Copy link
Collaborator

After rebasing this PR on main (in order to fix the broken version of vscode-extension-tester), this works well for me.

Copy link
Collaborator

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just took a look over the code

test/ui/cluster-ui-test.ts Outdated Show resolved Hide resolved
test/ui/cluster-ui-test.ts Outdated Show resolved Hide resolved
Signed-off-by: Lukas Grossmann <lgrossma@redhat.com>
@lgrossma lgrossma requested a review from datho7561 April 3, 2024 13:28
Copy link
Collaborator

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Lukas!

@datho7561 datho7561 merged commit 5921fdd into redhat-developer:main Apr 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants