Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show artifactId in the extensions picker #197

Closed
xorye opened this issue Jan 23, 2020 · 7 comments · Fixed by #239
Closed

Show artifactId in the extensions picker #197

xorye opened this issue Jan 23, 2020 · 7 comments · Fixed by #239
Labels
enhancement New feature or request wizards
Milestone

Comments

@xorye
Copy link
Contributor

xorye commented Jan 23, 2020

In the Quarkus guides, sometimes, extensions are referred to by the groupId + artifactId.

Examples:
https://quarkus.io/guides/kubernetes#add-readiness-and-liveness-probes
https://quarkus.io/guides/kubernetes#using-the-kubernetes-client
https://quarkus.io/guides/flyway#setting-up-support-for-flyway
https://quarkus.io/guides/qute#hello-world-with-jax-rs

Currently, the extensions picker does not display the groupdId or the artifactId, making it hard to identify which extensions the guides are referring to.

The artifactId was displayed before this PR: #165. It would be nice if we brought back the artifactId.

The extensions picker currently looks like this:
image

@fbricon fbricon added enhancement New feature or request wizards labels Jan 23, 2020
@xorye xorye changed the title Show groudpId in the extensions picker Show groupId in the extensions picker Jan 23, 2020
@xorye xorye changed the title Show groupId in the extensions picker Show artifactId in the extensions picker Jan 23, 2020
@xorye
Copy link
Contributor Author

xorye commented Jan 23, 2020

How does this look? In the gif, I am showing the artifactId when showing extension descriptions in place of the extension category:
Pick extensions demo with artifactId

@fbricon
Copy link
Collaborator

fbricon commented Jan 23, 2020

@xorye your image is missing

@xorye
Copy link
Contributor Author

xorye commented Jan 23, 2020

@fbricon it was a gif, does it work now?

Here is an image instead:
image

@xorye
Copy link
Contributor Author

xorye commented Jan 23, 2020

image

@xorye
Copy link
Contributor Author

xorye commented Mar 27, 2020

@fbricon what do you think about this?

demo gif

Here are some other options I explored:

Example A
image

Example B
image

Example C
image

Example D
image

Example E
image

@xorye
Copy link
Contributor Author

xorye commented Mar 27, 2020

IMHO I think the first gif seems pretty solid because it shows both groupId and artifactId (does it look to bloaty having both?) and still shows the category (Data, Messaging, Integration etc.) when you click on the icon on the top right corner

Having the groupId/artifactId and the category at the same time seems a bit messy.

It would be great if the detail section (the grey line underneath the extension name) could support newlines, but it seems like that's not possible. If we could put newlines, we could maybe put groupid/artifact in its own line.

@fbricon
Copy link
Collaborator

fbricon commented Mar 27, 2020

Yeah 1st example is the best. Allows you to toggle between light and bloaty but informative descriptions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wizards
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants