Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve application.properties TextMate grammar #233

Closed
xorye opened this issue Mar 17, 2020 · 2 comments · Fixed by #236
Closed

Improve application.properties TextMate grammar #233

xorye opened this issue Mar 17, 2020 · 2 comments · Fixed by #236
Assignees
Labels
bug Something isn't working
Milestone

Comments

@xorye
Copy link
Contributor

xorye commented Mar 17, 2020

There are pros and cons between the old textmate grammar and the new textmate grammar introduced in #230

Here are some cases where the two grammars act differently.

Multiline property keys (old grammar is preferable):

Old grammar:
image

New grammar:
image

Multiline property values (new grammar is preferable):

Old grammar:
image

New grammar:
image

Apostrophes (old grammar is preferable):

Old grammar:
image

New grammar:
image

For the new grammar, the issue about the apostrophes is here: textmate/ini.tmbundle#3 and the PR that fixes seems to fix that issue is here: textmate/ini.tmbundle#1

I've thought of three approaches we can take (please, by all means, suggest more approaches if there are better ones). The approaches are in no particular order.

To satisfy the cases above, we can either :

  • Go back to the old grammar and build on top of it

OR

  • Create issues in VS Code's repository to fix the grammars

OR

  • Build on top of the VS Code's grammar ourselves since 2. might take a long time
@angelozerr
Copy link
Contributor

angelozerr commented Mar 20, 2020

There is a problem with the current TextMate grammar with property key when property has slash:

org.acme.restclient.CountriesService/mp-rest/url=https://restcountries.eu/rest
configKey/mp-rest/url = 

image

@xorye xorye added this to the 1.4.0 milestone Mar 25, 2020
@xorye xorye self-assigned this Mar 25, 2020
@xorye xorye added the bug Something isn't working label Mar 25, 2020
@xorye
Copy link
Contributor Author

xorye commented Mar 25, 2020

@angelozerr I have now fixed that problem in my PR. If you have time, please try it out

@xorye xorye changed the title Improve application.properties textmate grammar Improve application.properties TextMate grammar Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants