Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote experimental Qute validation #438

Closed
angelozerr opened this issue Jan 14, 2022 · 1 comment · Fixed by #440
Closed

Promote experimental Qute validation #438

angelozerr opened this issue Jan 14, 2022 · 1 comment · Fixed by #440
Assignees
Labels
Milestone

Comments

@angelozerr
Copy link
Contributor

The Qute validation manages syntax error and semantic error (like undefined varriable, unknown property, etc). But it has some limitation like:

  • don't support infox notation
  • don't support bracket notation for property (ex : item['name'])

It means that there are error although it should not have errors. See comments at redhat-developer/quarkus-ls#451 (comment)

@maxandersen suggested disable the Qute validation by default.

To promote that Qute support is able to validate Qute template, it should be nice to show the first time a popup which ask if user want to activate the Experimental Qute validation:

  • yes -> will update the quarkus.tools.qute.validation.enabled settings to true
  • no -> do nothing

@fbricon @rgrunber as the popup must be displayed just the first time after (and not open this popup each time we open vscode), I think we need to manage a flag like openPopupToActivateExperimentalQuteValidation, where can we store it? I think vscode-quarkus already manage this kind of flag if I remember to open Overview page of Quarkus (not sure for that).

@fbricon
Copy link
Collaborator

fbricon commented Jan 14, 2022

you can use globalState to store the information. See https://stackoverflow.com/a/51822055/753170

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants