Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine if current project is a Quarkus project before adding Quarkus extensions #45

Closed
xorye opened this issue Aug 26, 2019 · 1 comment · Fixed by #204
Closed

Determine if current project is a Quarkus project before adding Quarkus extensions #45

xorye opened this issue Aug 26, 2019 · 1 comment · Fixed by #204
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@xorye
Copy link
Contributor

xorye commented Aug 26, 2019

The extension currently lets the user try to add Quarkus extensions even if a Maven Quarkus project is not open.

It would be great if we had something like this:

  1. Open a folder that does not contain a Quarkus project
  2. Invoke the "Quarkus: Add extensions to current project" command (which starts the vscode-quarkus extension since it is one of the activation events)
  3. vscode-quarkus then detects that we are not in a Quarkus project, and displays an error message.
@xorye xorye added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Aug 26, 2019
@xorye
Copy link
Contributor Author

xorye commented Aug 30, 2019

After calling "Quarkus: Add extensions to current project" command, there is an error message if a pom.xml cannot be found, but it would be great if we took it one step further and ensured that if we did find a pom.xml, ensure that it is for a Quarkus project.

@xorye xorye changed the title "Quarkus: Add extensions to current project" command appears even if a Quarkus project is not open. Determine if current project is a Quarkus project before adding Quarkus extensions. Aug 30, 2019
@xorye xorye self-assigned this Jan 10, 2020
@angelozerr angelozerr added this to the 1.4.0 milestone Feb 14, 2020
@xorye xorye changed the title Determine if current project is a Quarkus project before adding Quarkus extensions. Determine if current project is a Quarkus project before adding Quarkus extensions Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants