Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate initial input value, offer context on invalid values #84

Closed
maxandersen opened this issue Sep 19, 2019 · 2 comments · Fixed by #111
Closed

Validate initial input value, offer context on invalid values #84

maxandersen opened this issue Sep 19, 2019 · 2 comments · Fixed by #111
Assignees
Labels
bug Something isn't working
Milestone

Comments

@maxandersen
Copy link
Collaborator

When I run generate maven project the default value for artifact id is "MyQuarkusProject" and that gives two problems:

  1. when pressing enter on it the wizard does not move forward nor does it highlight the artifact id is not allowed.
  2. only when editing the field do you get an error highlighting the issue, but it just says "invalid artifact id" giving no hint on what is wrong - in this case seem to be that it has uppercase letters.

So would be good to have the validation error shown immediately or at least when pressing Enter and then tell user what is actually wrong with the artifact id or say what a valid one would be.

@maxandersen
Copy link
Collaborator Author

2019-09-19_11-10-29 (1)

here is me showing validation not showing up before I edit the value. Enter does not nothing.

@fbricon
Copy link
Collaborator

fbricon commented Sep 19, 2019

so the default value issue is fixed, you just need to make sure you delete the quarkus.tools.starter.defaults preference in you user settings.json

Still, the validation should happen whenever a default value is injected in the field, but I'm afraid that might be a vscode limitation at that point. I'll let @xorye look into it.

@fbricon fbricon added the bug Something isn't working label Sep 19, 2019
@fbricon fbricon added this to the 1.1.0 milestone Oct 17, 2019
@xorye xorye changed the title "invalid artifact id" with no real context/help Validate initial input value, offer context on invalid values Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants