Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add completion for CDATA block #168

Closed
EduFrazao opened this issue Jul 16, 2019 · 5 comments
Closed

Add completion for CDATA block #168

EduFrazao opened this issue Jul 16, 2019 · 5 comments
Assignees
@angelozerr
Labels
completion enhancement New feature or request
Milestone
0.8.0

Comments

@EduFrazao
Copy link

Hi folks. Its possible to enable CData blocks autocomplete? Or there is no such feature?
@angelozerr
Copy link
Contributor

You mean that completion provides

<![CDATA[ ]>

Is that?

@angelozerr angelozerr self-assigned this Jul 18, 2019
@angelozerr angelozerr added this to the 0.8.0 milestone Jul 18, 2019
angelozerr pushed a commit to eclipse/lemminx that referenced this issue Jul 18, 2019
CData block auto-complete
13482d2 
See redhat-developer/vscode-xml#168

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to eclipse/lemminx that referenced this issue Jul 19, 2019
CData block auto-complete
3511d04 
See redhat-developer/vscode-xml#168

Signed-off-by: azerr <azerr@redhat.com>
@EduFrazao
Copy link
Author

@angelozerr Yes, its exactly that feature. Thank you very mutch for this fast implementation!

@angelozerr angelozerr reopened this Jul 21, 2019
@angelozerr
Copy link
Contributor

@EduFrazao It's not finished, I'm implementing and I hope it will be available for 0.8..0.

angelozerr pushed a commit to eclipse/lemminx that referenced this issue Jul 22, 2019
CData block auto-complete
6ed9e1e 
See redhat-developer/vscode-xml#168

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to eclipse/lemminx that referenced this issue Jul 22, 2019
CData block auto-complete
a9ef7ea 
See redhat-developer/vscode-xml#168

Signed-off-by: azerr <azerr@redhat.com>
@angelozerr angelozerr mentioned this issue Jul 22, 2019
Merged
angelozerr pushed a commit to eclipse/lemminx that referenced this issue Jul 22, 2019
CData block auto-complete
b0a606c 
See redhat-developer/vscode-xml#168

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to eclipse/lemminx that referenced this issue Jul 22, 2019
CData block auto-complete
480ba5c 
See redhat-developer/vscode-xml#168

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to eclipse/lemminx that referenced this issue Jul 22, 2019
CData block auto-complete
3437d77 
See redhat-developer/vscode-xml#168

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to eclipse/lemminx that referenced this issue Jul 22, 2019
CData block auto-complete
fbefe18 
See redhat-developer/vscode-xml#168

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to eclipse/lemminx that referenced this issue Jul 22, 2019
CData block auto-complete
1611334 
See redhat-developer/vscode-xml#168

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to eclipse/lemminx that referenced this issue Jul 22, 2019
CData block auto-complete
b0ee501 
See redhat-developer/vscode-xml#168

Signed-off-by: azerr <azerr@redhat.com>
fbricon pushed a commit to eclipse/lemminx that referenced this issue Jul 22, 2019
@fbricon
CData block auto-complete
75e355d 
See redhat-developer/vscode-xml#168

Signed-off-by: azerr <azerr@redhat.com>
@fbricon
Copy link
Collaborator

fbricon commented Jul 22, 2019

Fixed with eclipse/lemminx#524

CommentCDataDemo2

@fbricon fbricon closed this as completed Jul 22, 2019
@EduFrazao
Copy link
Author

Very nice!
Thank you very mutch for your effort guys!

@angelozerr angelozerr added the enhancement New feature or request label Jul 23, 2019
@angelozerr angelozerr changed the title CData block auto-complete Add completion for CDATA block Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@angelozerr angelozerr

Labels
completion enhancement New feature or request
Projects
None yet
Milestone
0.8.0
Development

No branches or pull requests
3 participants
@fbricon @EduFrazao @angelozerr