Allows editing of start/end tag simultaneously

[NikolasKomonen]

Under the preference xml.autoSelectingMatchingTags

Fixes #130

Signed-off-by: Nikolas Komonen nikolaskomonen@gmail.com

[fbricon]

Can't get it to work. Output filled with errors like:

rejected promise not handled within 1 second: Error: Unsupported request method: xml/matchingTagPosition
extensionHostProcess.js:820
stack trace: Error: Unsupported request method: xml/matchingTagPosition
	at handleResponse (/Users/fbricon/Dev/projects/vscode-xml/dist/extension.js:6179:48)
	at processMessageQueue (/Users/fbricon/Dev/projects/vscode-xml/dist/extension.js:6006:17)
	at Immediate.<anonymous> (/Users/fbricon/Dev/projects/vscode-xml/dist/extension.js:5990:13)
	at processImmediate (internal/timers.js:439:21)

[fbricon]

When typing a space at the end of a tag, to add an attribute for instance, there's often an error logged because of cancelled request. Logs fill up pretty quickly so this should be handled more gracefully:

[NikolasKomonen]

When typing a space at the end of a tag, to add an attribute for instance, there's often an error logged because of cancelled request. Logs fill up pretty quickly so this should be handled more gracefully:

@fbricon I can't recreate this, but maybe it is using the bugged version of the code. I pushed the new one here, just pull the client again and hopefully this disappears.

[fbricon]

Works beautifully now, can't reproduce the issue from earlier.

That's a great feature, nice job @NikolasKomonen!

[fbricon]

Spoke too soon, I can still reproduce. add space at the end of a tag, delete, rinse, repeat until the exception shows up

[fbricon]

definitely reminds me of #149. We prolly need to make the server side more robust wrt cancelled commands

[fbricon]

I think the key here is "rejected promise not handled within 1 second". Server is too slow to respond, then client cancels the request.

[fbricon]

See https://stackoverflow.com/a/50124430/753170 for a potential solution

[NikolasKomonen]

See https://stackoverflow.com/a/50124430/753170 for a potential solution

Yup, this worked for me.

See: https://github.com/redhat-developer/vscode-xml/pull/204/files#diff-2a8a3831675ce7f9a5318a33b0485d7dR86

[fbricon]

No this doesn't work for me

[fbricon]

Now that've been playing with it, I think we need a new command to toggle the preference, so that, when bound to a keystroke, you can enter/exit quick tag edit mode

Also, the readme needs to be updated with the preference key (and documenting that new toggle command would help too)

[NikolasKomonen]

I think we need a new command to toggle the preference

Right now you can press Esc to stop the edit mode. Is that good enough?

Also, I have the README updated here in the PR here: https://github.com/redhat-developer/vscode-xml/pull/206/files#diff-04c6e90faac2675aa89e2176d2eec7d8R82

[fbricon]

Ctrl+Shift+F2 on linux/windows, Cmd+Shift+F2 on mac, to toggle matching tag editing

[NikolasKomonen]

@fbricon updated everything. The console error should be gone, cmd+shift+f2 should toggle the preference on your machine and a message should appear.

[fbricon]

please update the readme

[NikolasKomonen]

please update the readme

@fbricon the readme is updated in this PR: #206

[fbricon]

on configuration change, toggling the new pref should add/remove the mirror cursor immediately

[angelozerr]

what about using the same name than vscode mirrorCursorOnMatchingTag ?

[xorye]

on configuration change, toggling the new pref should add/remove the mirror cursor immediately

I implemented that here: https://github.com/xorye/vscode-xml/tree/matchingTagClient

[fbricon]

superseded by #207