Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completion for xsd:enumeration inside of text node #218

Closed
arkceajin opened this issue Jan 9, 2020 · 4 comments · Fixed by eclipse/lemminx#632
Closed

Completion for xsd:enumeration inside of text node #218

arkceajin opened this issue Jan 9, 2020 · 4 comments · Fixed by eclipse/lemminx#632
Assignees
Labels
completion enhancement New feature or request
Milestone

Comments

@arkceajin
Copy link

arkceajin commented Jan 9, 2020

xsd: https://github.com/redhat-developer/vscode-xml/files/4029276/AUTOSAR_00048.zip
xml:

<?xml version="1.0" encoding="UTF-8"?>
<AUTOSAR xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://autosar.org/schema/r4.0" xsi:schemaLocation="http://autosar.org/schema/r4.0 AUTOSAR_00048.xsd">
	<AR-PACKAGES>
		<AR-PACKAGE>
			<SHORT-NAME>aubist</SHORT-NAME>
			<AR-PACKAGES>
				<AR-PACKAGE>
					<SHORT-NAME>ara</SHORT-NAME>
					<ELEMENTS>
						<SOFTWARE-PACKAGE>
							<SHORT-NAME>test</SHORT-NAME>
							<ACTION-TYPE></ACTION-TYPE>
						</SOFTWARE-PACKAGE>
					</ELEMENTS>
				</AR-PACKAGE>
			</AR-PACKAGES>
		</AR-PACKAGE>
	</AR-PACKAGES>
</AUTOSAR>

For tag <ACTION-TYPE> suppose allow these values

  • INSTALL
  • REMOVE
  • UPDATE

But now gives nothing, suggest show the autocomplete as above.
image

@angelozerr angelozerr changed the title xsd:enumeration autocomplete don't work xsd:enumeration autocomplete don't work for text node Jan 9, 2020
@angelozerr
Copy link
Contributor

angelozerr commented Jan 9, 2020

Indeed completion based on xsd:enumeration works for attribute value but not for text node. We should implement it.

@fbricon fbricon added the enhancement New feature or request label Apr 2, 2020
angelozerr pushed a commit to angelozerr/lemminx that referenced this issue Apr 9, 2020
angelozerr pushed a commit to angelozerr/lemminx that referenced this issue Apr 9, 2020
@angelozerr
Copy link
Contributor

This issue is not very hard, I will implement it soon.

angelozerr pushed a commit to angelozerr/lemminx that referenced this issue Apr 10, 2020
angelozerr pushed a commit to angelozerr/lemminx that referenced this issue Apr 10, 2020
@angelozerr angelozerr self-assigned this Apr 11, 2020
@angelozerr angelozerr added this to the 0.12.0 milestone Apr 11, 2020
angelozerr pushed a commit to angelozerr/lemminx that referenced this issue Apr 13, 2020
@angelozerr
Copy link
Contributor

angelozerr commented Apr 13, 2020

I created a PR to support this issue at eclipse/lemminx#632 (it's soon finished), here a demo:

XSDEnumerationOnText

angelozerr pushed a commit to angelozerr/lemminx that referenced this issue Apr 13, 2020
angelozerr pushed a commit to angelozerr/lemminx that referenced this issue Apr 13, 2020
angelozerr pushed a commit to angelozerr/lemminx that referenced this issue Apr 13, 2020
angelozerr pushed a commit to angelozerr/lemminx that referenced this issue Apr 13, 2020
angelozerr pushed a commit to angelozerr/lemminx that referenced this issue Apr 13, 2020
angelozerr pushed a commit to angelozerr/lemminx that referenced this issue Apr 14, 2020
angelozerr pushed a commit to angelozerr/lemminx that referenced this issue Apr 14, 2020
angelozerr pushed a commit to eclipse/lemminx that referenced this issue Apr 14, 2020
@arkceajin
Copy link
Author

thanks, it looks great.

@xorye xorye changed the title xsd:enumeration autocomplete don't work for text node Completion for xsd:enumeration inside of text node Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completion enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants