Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically closing tags in multi-cursor mode only closes one tag #225

Closed
ckoppelman opened this issue Feb 5, 2020 · 2 comments · Fixed by #490
Closed

Automatically closing tags in multi-cursor mode only closes one tag #225

ckoppelman opened this issue Feb 5, 2020 · 2 comments · Fixed by #490
Assignees
Labels
bug Something isn't working completion
Milestone

Comments

@ckoppelman
Copy link

Description

In multi-cursor mode, the autocompletion only completes one XML Tag.

Steps to reproduce

  1. Set "xml.completion.autoCloseTags": true.
  2. Type the following (pipes indicate multiple cursor locations):
    <lib|
    <lib|
    <lib|
    <lib|
  1. Type >

Expected

I expect the document to look like this:

    <lib>|</lib>
    <lib>|</lib>
    <lib>|</lib>
    <lib>|</lib>

Actual

Instead, the document looks like this:

    <lib>|</lib>
    <lib>|
    <lib>|
    <lib>|
@ckoppelman ckoppelman changed the title Automatically closing tags in multi-cursor mode is broken Automatically closing tags in multi-cursor mode only completes one tag Feb 5, 2020
@ckoppelman ckoppelman changed the title Automatically closing tags in multi-cursor mode only completes one tag Automatically closing tags in multi-cursor mode only closes one tag Feb 5, 2020
@belaw
Copy link

belaw commented Mar 24, 2021

If you use multi-cursor a lot, this is a deal breaker

@datho7561 datho7561 added the enhancement New feature or request label May 25, 2021
@angelozerr angelozerr added bug Something isn't working completion and removed enhancement New feature or request labels Jun 1, 2021
angelozerr pushed a commit to angelozerr/vscode-xml that referenced this issue Jun 1, 2021
@angelozerr
Copy link
Contributor

If you use multi-cursor a lot, this is a deal breaker

Sorry I just discovered this issue now :) I'm fixing.

angelozerr pushed a commit to angelozerr/vscode-xml that referenced this issue Jun 4, 2021
angelozerr pushed a commit to angelozerr/vscode-xml that referenced this issue Jun 4, 2021
angelozerr pushed a commit to angelozerr/vscode-xml that referenced this issue Jun 4, 2021
@datho7561 datho7561 added this to the 0.17.0 milestone Jun 4, 2021
datho7561 pushed a commit that referenced this issue Jun 4, 2021
Fixes #225

Signed-off-by: azerr <azerr@redhat.com>
AlexXuChen pushed a commit to AlexXuChen/vscode-xml that referenced this issue Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working completion
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants