Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LemMinx extensions via vscode user settings #251

Closed
angelozerr opened this issue May 1, 2020 · 5 comments · Fixed by #336
Closed

Add LemMinx extensions via vscode user settings #251

angelozerr opened this issue May 1, 2020 · 5 comments · Fixed by #336
Assignees
Milestone

Comments

@angelozerr
Copy link
Contributor

angelozerr commented May 1, 2020

LemMinx is extensible to manage custom completion, validation, etc. https://github.com/eclipse/lemminx-maven is a good sample of extension which provides support for maven.

To use this extension, it requires to create a vscode extension (eg: https://github.com/angelozerr/vscode-xml-maven)

This issue is to provide a new xml settings like xml.extension.jars which is an array of String which defines paths from LemMinx JAR extensions. to use when classpath is created

@AObuchow
Copy link

+1, this is the VSCode equivalent of the lemminxExtension in Wild Web Developer (although simpler for non-VSCode developers to use).

@AObuchow
Copy link

@angelozerr how hard do you think it would be for someone who has never wrote (but has read a lot of) TypeScript :) Maybe I should try to fix this bug in my spare time.

@angelozerr
Copy link
Contributor Author

I think it's not a big deal. The idea is to

  1. add a new method which read configuration :

let classPathFromSettings = workspace.getConfiguration("xml.server").get("extensions");

like

let currentVMArgs = workspace.getConfiguration("xml.server").get("vmargs");

  1. call this method in

let xmlJavaExtensionsClasspath = '';

  1. declare the settings in package.json like
    "xml.server.workDir": {

@fbricon for the settings name I suggest xml.server.extensions which is an array of JAR, what do you think about that ?

@angelozerr
Copy link
Contributor Author

@AObuchow is there any chance that you work on this issue? I think it could be a nice feature to test quickly the LemMinx maven support inside vscode.

@AObuchow
Copy link

Wow I was just thinking about this yesterday night, good timing @angelozerr ;)

I’ll see with my team how much of a priority this is. It might be that I’ll work on it in my spare time. I’m about to release my first Eclipse plugin on the marketplace (probably tomorrow) but after that I want to get this done :)

datho7561 added a commit to datho7561/vscode-xml that referenced this issue Oct 6, 2020
Adds a new setting `xml.extension.jars`, where you can list jars to contribute
to the LemMinX classpath. You can use this feature to test LemMinX
extensions in VSCode.

Closes redhat-developer#251

Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561 datho7561 self-assigned this Oct 6, 2020
datho7561 added a commit to datho7561/vscode-xml that referenced this issue Oct 6, 2020
Adds a new setting `xml.extension.jars`, where you can list jars to contribute
to the LemMinX classpath. You can use this feature to test LemMinX
extensions in VSCode.

Closes redhat-developer#251

Signed-off-by: David Thompson <davthomp@redhat.com>
@angelozerr angelozerr added this to the 0.14.0 milestone Oct 7, 2020
@angelozerr angelozerr removed their assignment Oct 7, 2020
@fbricon fbricon changed the title Add LemMinx extension with vscode user settings Add LemMinx extensions via vscode user settings Oct 7, 2020
datho7561 added a commit to datho7561/vscode-xml that referenced this issue Oct 7, 2020
Adds a new setting `xml.extension.jars`, where you can list jars to contribute
to the LemMinX classpath. You can use this feature to test LemMinX
extensions in VSCode.

Closes redhat-developer#251

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/vscode-xml that referenced this issue Oct 7, 2020
Adds a new setting `xml.extension.jars`, where you can list jars to contribute
to the LemMinX classpath. You can use this feature to test LemMinX
extensions in VSCode.

Closes redhat-developer#251

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/vscode-xml that referenced this issue Oct 9, 2020
Adds a new setting `xml.extension.jars`, where you can list jars to contribute
to the LemMinX classpath. You can use this feature to test LemMinX
extensions in VSCode.

Closes redhat-developer#251

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/vscode-xml that referenced this issue Oct 9, 2020
Adds a new setting `xml.extension.jars`, where you can list jars to contribute
to the LemMinX classpath. You can use this feature to test LemMinX
extensions in VSCode.

Closes redhat-developer#251

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/vscode-xml that referenced this issue Oct 9, 2020
Adds a new setting `xml.extension.jars`, where you can list jars to contribute
to the LemMinX classpath. You can use this feature to test LemMinX
extensions in VSCode.

Closes redhat-developer#251

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/vscode-xml that referenced this issue Oct 9, 2020
Adds a new setting `xml.extension.jars`, where you can list jars to contribute
to the LemMinX classpath. You can use this feature to test LemMinX
extensions in VSCode.

Closes redhat-developer#251

Signed-off-by: David Thompson <davthomp@redhat.com>
angelozerr pushed a commit that referenced this issue Oct 9, 2020
Adds a new setting `xml.extension.jars`, where you can list jars to contribute
to the LemMinX classpath. You can use this feature to test LemMinX
extensions in VSCode.

Closes #251

Signed-off-by: David Thompson <davthomp@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants