Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completion & hover based on XSD with elementFormDefault="unqualified" doesn't work #311

Closed
ynohat opened this issue Aug 19, 2020 · 7 comments
Assignees
Labels
bug Something isn't working completion hover xsd
Milestone

Comments

@ynohat
Copy link

ynohat commented Aug 19, 2020

Hi!

I am attaching an example XML file (examples/itops.xml) along with supporting schemata and a catalog (that I have setup in VS Code).

Autocomplete works on the fields under the root tag, but not children. Everything seems valid (but I'm no guru). Eclipse WTP (2020-06) autocompletes, using the same catalog and files.

rh-vscode.zip

Note that there are several schemata imported, and they use elementFormDefault="unqualified" (a UX choice, that could be revisited if proven anti-standard).

Thanks a lot for an amazing extension!

@angelozerr
Copy link
Contributor

Autocomplete works on the fields under the root tag, but not children.

For your usecase you mena after templates you hav enone completion (like Site), I supsect it's a problem with namespaceURI computing.

Thanks a lot for an amazing extension!

Thanks!

@ynohat
Copy link
Author

ynohat commented Aug 20, 2020

@angelozerr thanks! do you feel that there is a workaround I can implement?

@angelozerr angelozerr changed the title autocomplete not working (as well as eclipse) Completion & hover based on XSD with elementFormDefault="unqualified" doesn't work Aug 25, 2020
angelozerr pushed a commit to angelozerr/lemminx that referenced this issue Aug 25, 2020
elementFormDefault="unqualified"

See redhat-developer/vscode-xml#311

Signed-off-by: azerr <azerr@redhat.com>
@angelozerr
Copy link
Contributor

@ynohat I fixed the problem in PR eclipse/lemminx#855 Please wait for merging this PR and after that you will able to install vsix and try it.

@angelozerr angelozerr self-assigned this Aug 25, 2020
@angelozerr angelozerr added this to the 0.14.0 milestone Aug 25, 2020
@angelozerr angelozerr added bug Something isn't working completion hover xsd labels Aug 25, 2020
angelozerr pushed a commit to angelozerr/lemminx that referenced this issue Aug 25, 2020
elementFormDefault="unqualified"

See redhat-developer/vscode-xml#311

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to angelozerr/lemminx that referenced this issue Aug 25, 2020
elementFormDefault="unqualified"

See redhat-developer/vscode-xml#311

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to eclipse/lemminx that referenced this issue Aug 26, 2020
elementFormDefault="unqualified"

See redhat-developer/vscode-xml#311

Signed-off-by: azerr <azerr@redhat.com>
@angelozerr
Copy link
Contributor

Fixed by eclipse/lemminx#855

@ynohat
Copy link
Author

ynohat commented Aug 26, 2020

Hi @angelozerr, thanks again for your quick response to this! Is this now in the following vsix?

vscode-xml-0.14.0-10301.vsix | 26-Aug-2020 03:50 | 7.0M

@ynohat
Copy link
Author

ynohat commented Aug 26, 2020

Just tested, and it seems to be working now 🥇

@angelozerr
Copy link
Contributor

Just tested, and it seems to be working now

Great! Thanks for your feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working completion hover xsd
Projects
None yet
Development

No branches or pull requests

2 participants