Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calling extension.ts -> activate() method fails in 0.15.0 #418

Closed
jag-j opened this issue Feb 11, 2021 · 1 comment · Fixed by #421
Closed

Calling extension.ts -> activate() method fails in 0.15.0 #418

jag-j opened this issue Feb 11, 2021 · 1 comment · Fixed by #421
Labels
bug Something isn't working
Milestone
0.16.0

Comments

@jag-j
Copy link

jag-j commented Feb 11, 2021

There is a regression in 0.15.0 likely due to these changes - 5495a0e.

The following code used to work in 0.14.0, but now extensionApi is 'undefined'.

const redHatExtension = vscode.extensions.getExtension('redhat.vscode-xml');
const extensionApi = await redHatExtension!.activate();
@angelozerr
Copy link
Contributor

Is there any chance to have a PR to fix this bug?

@angelozerr angelozerr mentioned this issue Feb 12, 2021
Merged
datho7561 added a commit to datho7561/vscode-xml that referenced this issue Feb 23, 2021
@datho7561
Refactor to improve readability
e32706e 
Use `await` in `extension.ts`.
Move some functionality out of `extension.ts`.
Move some TypeScript files into subfolders.
Fix `.editorconfig`.

Fixes redhat-developer#418

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/vscode-xml that referenced this issue Feb 23, 2021
@datho7561
Refactor to improve readability
2e2d6ec 
Use `await` in `extension.ts`.
Move some functionality out of `extension.ts`.
Move some TypeScript files into subfolders.
Fix `.editorconfig`.

Fixes redhat-developer#418

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/vscode-xml that referenced this issue Feb 24, 2021
@datho7561
Refactor to improve readability
37957ad 
Use `await` in `extension.ts`.
Move some functionality out of `extension.ts`.
Move some TypeScript files into subfolders.
Fix `.editorconfig`.

Fixes redhat-developer#418

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/vscode-xml that referenced this issue Feb 24, 2021
@datho7561
Refactor to improve readability
7bdf609 
Use `await` in `extension.ts`.
Move some functionality out of `extension.ts`.
Move some TypeScript files into subfolders.
Fix `.editorconfig`.

Fixes redhat-developer#418

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/vscode-xml that referenced this issue Feb 24, 2021
@datho7561
Refactor to improve readability
ba097a2 
Use `await` in `extension.ts`.
Move some functionality out of `extension.ts`.
Move some TypeScript files into subfolders.
Fix `.editorconfig`.

Fixes redhat-developer#418

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/vscode-xml that referenced this issue Feb 24, 2021
@datho7561
Refactor to improve readability
0fd4874 
Use `await` in `extension.ts`.
Move some functionality out of `extension.ts`.
Move some TypeScript files into subfolders.
Fix `.editorconfig`.

Fixes redhat-developer#418

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/vscode-xml that referenced this issue Feb 24, 2021
@datho7561
Refactor to improve readability
34d84a7 
Use `await` in `extension.ts`.
Move some functionality out of `extension.ts`.
Move some TypeScript files into subfolders.
Fix `.editorconfig`.

Fixes redhat-developer#418

Signed-off-by: David Thompson <davthomp@redhat.com>
angelozerr pushed a commit that referenced this issue Feb 25, 2021
@datho7561 @angelozerr
Refactor to improve readability
728c669 
Use `await` in `extension.ts`.
Move some functionality out of `extension.ts`.
Move some TypeScript files into subfolders.
Fix `.editorconfig`.

Fixes #418

Signed-off-by: David Thompson <davthomp@redhat.com>
@angelozerr angelozerr added the bug Something isn't working label Mar 5, 2021
@angelozerr angelozerr added this to the 0.16.0 milestone Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.16.0
Development

Successfully merging a pull request may close this issue.

Refactor to improve readability datho7561/vscode-xml
2 participants
@angelozerr @jag-j