Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"xml.validation.noGrammar" no longer works #467

Closed
fbricon opened this issue May 5, 2021 · 0 comments · Fixed by eclipse/lemminx#1024
Closed

"xml.validation.noGrammar" no longer works #467

fbricon opened this issue May 5, 2021 · 0 comments · Fixed by eclipse/lemminx#1024
Assignees
@datho7561
Labels
bug Something isn't working regression validation
Milestone
0.16.1

Comments

@fbricon
Copy link
Collaborator

fbricon commented May 5, 2021

xml.validation.noGrammar no longer works, no matter what value is set, validation considers it's set to hint

May-05-2021.10-22-23.mp4
@fbricon fbricon added bug Something isn't working validation regression labels May 5, 2021
@fbricon fbricon added this to the 0.17.0 milestone May 5, 2021
@datho7561 datho7561 self-assigned this May 5, 2021
@datho7561 datho7561 mentioned this issue May 6, 2021
Merged
datho7561 added a commit to datho7561/lemminx that referenced this issue May 6, 2021
@datho7561
Fix ability to disable "no grammar" message
1a8c030 
Fixes redhat-developer/vscode-xml#467

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/lemminx that referenced this issue May 6, 2021
@datho7561
Fix ability to disable "no grammar" message
aa168a2 
Fixes redhat-developer/vscode-xml#467

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/lemminx that referenced this issue May 6, 2021
@datho7561
Fix ability to disable "no grammar" message
ba8ea79 
Fixes redhat-developer/vscode-xml#467

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/lemminx that referenced this issue May 6, 2021
@datho7561
Fix ability to disable "no grammar" message
00ee4bc 
Fixes redhat-developer/vscode-xml#467

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/lemminx that referenced this issue May 6, 2021
@datho7561
Fix ability to disable "no grammar" message
506c401 
Fixes redhat-developer/vscode-xml#467

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to eclipse/lemminx that referenced this issue May 6, 2021
@datho7561
Fix ability to disable "no grammar" message
74cfa7a 
Fixes redhat-developer/vscode-xml#467

Signed-off-by: David Thompson <davthomp@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@datho7561 datho7561

Labels
bug Something isn't working regression validation
Projects
None yet
Milestone
0.16.1
Development

Successfully merging a pull request may close this issue.

Fix ability to disable "no grammar" message datho7561/lemminx
2 participants
@fbricon @datho7561