Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal documentation doesn't support links to pages in parent directories #499

Closed
datho7561 opened this issue Jun 8, 2021 · 0 comments · Fixed by #502
Closed

Internal documentation doesn't support links to pages in parent directories #499

datho7561 opened this issue Jun 8, 2021 · 0 comments · Fixed by #502
Assignees
@datho7561
Labels
bug Something isn't working
Milestone
0.17.0

Comments

@datho7561
Copy link
Contributor

If you have an internal documentation page in a folder nested under docs (i.e. docs/Features/XMLFeatures.md) and this Markdown page has a link to a Markdown page in the parent folder (i.e. ../CodeLens.md, meaning docs/CodeLens.md ), then this link will not work properly in the internal documentation.
@datho7561 datho7561 added the bug Something isn't working label Jun 8, 2021
datho7561 added a commit to datho7561/vscode-xml that referenced this issue Jun 8, 2021
@datho7561
Fix links to parent folder in internal docs
44ab715 
If you link to a file in the parent directory from a markdown file in a
nested folder, the link will now function correctly in the embedded
documentation.
The embedded documentation is the documentation that's available through
the "XML: Open XML Documentation" command.

Fixes redhat-developer#499

Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561 datho7561 mentioned this issue Jun 8, 2021
Merged
@datho7561 datho7561 self-assigned this Jun 9, 2021
datho7561 added a commit to datho7561/vscode-xml that referenced this issue Jun 9, 2021
@datho7561
Fix links to parent folder in internal docs
321b50d 
If you link to a file in the parent directory from a markdown file in a
nested folder, the link will now function correctly in the embedded
documentation.
The embedded documentation is the documentation that's available through
the "XML: Open XML Documentation" command.

Fixes redhat-developer#499

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit that referenced this issue Jun 21, 2021
@datho7561
Fix links to parent folder in internal docs
e1b1a9b 
If you link to a file in the parent directory from a markdown file in a
nested folder, the link will now function correctly in the embedded
documentation.
The embedded documentation is the documentation that's available through
the "XML: Open XML Documentation" command.

Fixes #499

Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561 datho7561 added this to the 0.17.0 milestone Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@datho7561 datho7561

Labels
bug Something isn't working
Projects
None yet
Milestone
0.17.0
Development

Successfully merging a pull request may close this issue.

Fix links to parent folder in internal docs datho7561/vscode-xml
1 participant
@datho7561