XML Language Server keeps restarting when running out of memory #527
Comments
|
So I managed to reproduce the issue by setting "xml.server.vmargs": "-Xmx8M" (down from the default -Xmx64M): java.lang.OutOfMemoryError should be detected by vscode-xml and let users know about it, propose a fix (eg. increase heap by setting "xml.server.vmargs": "-Xmx128M") |
fbricon
changed the title
|
Some users send over 1400 restart events a day, every day. |
|
Thanks for opening this issue so I can just add to it. I do experience this as soon as I have one big XML file opened (with the default args I can reproduce this with a 30MB file). As the server is used for all opened XML files I can't use the plugin for any XML file until I find the one that's big and close it. I suggest to:
Question: is the log-view and the actual OutOfMemoryBounds something that should be visible? I've needed to increase the setting from the default to 256MB to show the following: More suggestions:
|
|
If the client can detect the OOM, maybe we can have a prompt asking the user whether to restart with -Xmx increased by some amount. We discussed this in #489 (comment) . Maybe we can also report the stacktrace. |
datho7561
added a commit
to datho7561/vscode-xml
that referenced
this issue
Jul 13, 2021
Add parameters to the java server to make lemminx crash when it runs out of memory. Detect when the java server shuts down due to running out of memory, display a message to the user that this happened, and don't attempt to restart the server. Closes redhat-developer#527 Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561
added a commit
to datho7561/vscode-xml
that referenced
this issue
Jul 15, 2021
Add parameters to the java server to make lemminx crash when it runs out of memory. Detect when the java server shuts down due to running out of memory, display a message to the user that this happened, and don't attempt to restart the server. Closes redhat-developer#527 Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561
added a commit
to datho7561/vscode-xml
that referenced
this issue
Jul 19, 2021
Add parameters to the java server to make lemminx crash when it runs out of memory. Detect when the java server shuts down due to running out of memory, display a message to the user that this happened, and don't attempt to restart the server. Closes redhat-developer#527 Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561
added a commit
to datho7561/vscode-xml
that referenced
this issue
Jul 19, 2021
Add parameters to the java server to make lemminx crash when it runs out of memory. Detect when the java server shuts down due to running out of memory, display a message to the user that this happened, and don't attempt to restart the server. Closes redhat-developer#527 Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561
added a commit
to datho7561/vscode-xml
that referenced
this issue
Jul 19, 2021
Add parameters to the java server to make lemminx crash when it runs out of memory. Detect when the java server shuts down due to running out of memory, display a message to the user that this happened, and don't attempt to restart the server. Closes redhat-developer#527 Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561
added a commit
to datho7561/vscode-xml
that referenced
this issue
Jul 19, 2021
Add parameters to the java server to make lemminx crash when it runs out of memory. Detect when the java server shuts down due to running out of memory, display a message to the user that this happened, and don't attempt to restart the server. Closes redhat-developer#527 Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561
added a commit
to datho7561/vscode-xml
that referenced
this issue
Jul 19, 2021
Add parameters to the java server to make lemminx crash when it runs out of memory. Detect when the java server shuts down due to running out of memory, display a message to the user that this happened, and don't attempt to restart the server. Closes redhat-developer#527 Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561
added a commit
to datho7561/vscode-xml
that referenced
this issue
Jul 19, 2021
Add parameters to the java server to make lemminx crash when it runs out of memory. Detect when the java server shuts down due to running out of memory, display a message to the user that this happened, and don't attempt to restart the server. Closes redhat-developer#527 Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561
added a commit
to datho7561/vscode-xml
that referenced
this issue
Jul 26, 2021
Add parameters to the java server to make lemminx crash when it runs out of memory. Detect when the java server shuts down due to running out of memory, display a message to the user that this happened, and don't attempt to restart the server. Closes redhat-developer#527 Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561
added a commit
to datho7561/vscode-xml
that referenced
this issue
Jul 28, 2021
Add parameters to the java server to make lemminx crash when it runs out of memory. Detect when the java server shuts down due to running out of memory, display a message to the user that this happened, and don't attempt to restart the server. Closes redhat-developer#527 Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561
added a commit
to datho7561/vscode-xml
that referenced
this issue
Jul 28, 2021
Add parameters to the java server to make lemminx crash when it runs out of memory. Detect when the java server shuts down due to running out of memory, display a message to the user that this happened, and don't attempt to restart the server. Closes redhat-developer#527 Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561
added a commit
to datho7561/vscode-xml
that referenced
this issue
Jul 28, 2021
Add parameters to the java server to make lemminx crash when it runs out of memory. Detect when the java server shuts down due to running out of memory, display a message to the user that this happened, and don't attempt to restart the server. Closes redhat-developer#527 Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561
added a commit
to datho7561/vscode-xml
that referenced
this issue
Jul 28, 2021
Add parameters to the java server to make lemminx crash when it runs out of memory. Detect when the java server shuts down due to running out of memory, display a message to the user that this happened, and don't attempt to restart the server. Closes redhat-developer#527 Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561
added a commit
to datho7561/vscode-xml
that referenced
this issue
Jul 29, 2021
Add parameters to the java server to make lemminx crash when it runs out of memory. Detect when the java server shuts down due to running out of memory, display a message to the user that this happened, and don't attempt to restart the server. Closes redhat-developer#527 Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561
added a commit
to datho7561/vscode-xml
that referenced
this issue
Jul 29, 2021
Add parameters to the java server to make lemminx crash when it runs out of memory. Detect when the java server shuts down due to running out of memory, display a message to the user that this happened, and don't attempt to restart the server. Closes redhat-developer#527 Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561
added a commit
that referenced
this issue
Aug 4, 2021
Add parameters to the java server to make lemminx crash when it runs out of memory. Detect when the java server shuts down due to running out of memory, display a message to the user that this happened, and don't attempt to restart the server. Closes #527 Signed-off-by: David Thompson <davthomp@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Telemetry data tells us a few users (< 0.1%) have their XML Language Server restarting every minute. Since this is a slower rate than 5 times in less than 3 minutes, it doesn't bubble up to the user.
Still, this indicates a problem and I have no idea what can cause it. Until we find a solution, we need to get better information (from telemetry) to figure out what's causing this.
The text was updated successfully, but these errors were encountered: