Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should publish a generic vsix #865

Closed
fbricon opened this issue Jan 27, 2023 · 0 comments · Fixed by #866
Closed

Should publish a generic vsix #865

fbricon opened this issue Jan 27, 2023 · 0 comments · Fixed by #866
Assignees
@rgrunber
Labels
build
Milestone
0.24.0

Comments

@fbricon
Copy link
Collaborator

fbricon commented Jan 27, 2023

Only a subset of platforms are covered here, instead of publishing a generic vsix.

vscode-xml/Jenkinsfile

Line 127 in a179451

sh 'vsce publish -p ${TOKEN} --target win32-ia32 win32-arm64 linux-arm64 linux-armhf alpine-x64 alpine-arm64' + " ${env.publishPreReleaseFlag}"

Similar to redhat-developer/vscode-java#2880
@fbricon fbricon added the build label Jan 27, 2023
@fbricon fbricon added this to the 0.24.0 milestone Jan 27, 2023
@fbricon fbricon mentioned this issue Jan 27, 2023
Merged
rgrunber added a commit to rgrunber/vscode-xml that referenced this issue Jan 27, 2023
@rgrunber
Publish a generic vsix for all other platforms.
65845fd 
- Instead of publishing a generic vsix for marketplace platforms that we
  cannot support, simply continue to publish a generic vsix
- Publish platform-specific extensions, and pre-releases on Open VSX
- Fixes redhat-developer#865

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
@rgrunber rgrunber mentioned this issue Jan 27, 2023
Merged
rgrunber added a commit to rgrunber/vscode-xml that referenced this issue Jan 27, 2023
@rgrunber
Publish a generic vsix for all other platforms.
37ca477 
- Instead of publishing a generic vsix for marketplace platforms that we
  cannot support, simply continue to publish a generic vsix
- Publish platform-specific extensions, and pre-releases on Open VSX
- Fixes redhat-developer#865

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
datho7561 pushed a commit that referenced this issue Jan 27, 2023
@rgrunber @datho7561
Publish a generic vsix for all other platforms.
5fa94b8 
- Instead of publishing a generic vsix for marketplace platforms that we
  cannot support, simply continue to publish a generic vsix
- Publish platform-specific extensions, and pre-releases on Open VSX
- Fixes #865

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rgrunber rgrunber

Labels
build
Projects
IDE Raptors
Archived in project
Milestone
0.24.0
Development

Successfully merging a pull request may close this issue.

Publish a generic vsix for all other platforms. rgrunber/vscode-xml
2 participants
@fbricon @rgrunber