Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade engine to "^1.67.0" #872

Closed
datho7561 opened this issue Jan 31, 2023 · 0 comments · Fixed by #894
Closed

Upgrade engine to "^1.67.0" #872

datho7561 opened this issue Jan 31, 2023 · 0 comments · Fixed by #894
Assignees
@datho7561
Labels
bug Something isn't working
Milestone
0.25.0

Comments

@datho7561
Copy link
Contributor

datho7561 commented Jan 31, 2023 •
edited

In the package.json, we say that we require VS Code "^1.63.0", but since we upgraded to a newer language client, we actually rely on VS Code "^1.67.0". We should upgrade the listed engine version so that older versions of VS Code are prevented from installing the extension.
@datho7561 datho7561 added the bug Something isn't working label Jan 31, 2023
@datho7561 datho7561 mentioned this issue Apr 17, 2023
Merged
datho7561 added a commit to datho7561/vscode-xml that referenced this issue Apr 17, 2023
@datho7561
Update VS Code engine to ^1.67.0
5e198ec 
Fixes redhat-developer#872

Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561 datho7561 added this to the 0.25.0 milestone Apr 17, 2023
@datho7561 datho7561 self-assigned this Apr 17, 2023
datho7561 added a commit that referenced this issue Apr 17, 2023
@datho7561
Update VS Code engine to ^1.67.0
0c7cb62 
Fixes #872

Signed-off-by: David Thompson <davthomp@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@datho7561 datho7561

Labels
bug Something isn't working
Projects
None yet
Milestone
0.25.0
Development

Successfully merging a pull request may close this issue.

Update VS Code engine to ^1.67.0 datho7561/vscode-xml
1 participant
@datho7561