Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JRE support #152

Merged
merged 1 commit into from
Jun 5, 2019
Merged

JRE support #152

merged 1 commit into from
Jun 5, 2019

Conversation

xorye
Copy link

@xorye xorye commented Jun 5, 2019

JRE path can now be detected automatically. This was tested on a machine with JRE, but without JDK.

This PR branch was initially taken from #136 .

Signed-off-by: David Kwon dakwon@redhat.com

@fbricon
Copy link
Collaborator

fbricon commented Jun 5, 2019

Please also update the readme

@xorye
Copy link
Author

xorye commented Jun 5, 2019

Updated. Does this suffice?

@xorye
Copy link
Author

xorye commented Jun 5, 2019

On second thought, I will add some more information.

@fbricon
Copy link
Collaborator

fbricon commented Jun 5, 2019

OK this work but i found an issue with the code you changed from ef91528#diff-baff02b04010a735985f63100efb9fc2L37:

each case is checked even after the java home path has been found. For some reason, it doesn't cause an error because apparently the 1st call to resolve wins. The old code, albeit uglier, used to better handle one case after the other

@xorye
Copy link
Author

xorye commented Jun 5, 2019

Yes, that was one of the benefits of the previous version. It turns out that when resolve() is called, it still executes everything else after it, but the first resolve is always the result that the promise returns. Do you want me to change it back to the previous way?

@fbricon
Copy link
Collaborator

fbricon commented Jun 5, 2019

Yes please

… in xml.java home, java.home, or detect automatically.

Signed-off-by: David Kwon <dakwon@redhat.com>
@xorye
Copy link
Author

xorye commented Jun 5, 2019

I have reverted it

@fbricon fbricon merged commit 840fb4e into redhat-developer:master Jun 5, 2019
@fbricon fbricon added this to the v0.7.0 milestone Jun 10, 2019
@fbricon fbricon added the enhancement New feature or request label Jun 10, 2019
@fbricon fbricon mentioned this pull request Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants