Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix debug mode detection #266

Merged
merged 1 commit into from
May 29, 2020

Conversation

fbricon
Copy link
Collaborator

@fbricon fbricon commented May 28, 2020

It was no longer possible to start a remote Java debugger on lemminx,
because the debug flags used to start the hosted vscode extension have changed.

It was no longer possible to start a remote Java debugger on lemminx,
because the debug flags used to start the hosted vscode extension have changed.

Signed-off-by: Fred Bricon <fbricon@gmail.com>
@fbricon fbricon requested a review from xorye May 28, 2020 14:11
@fbricon fbricon added this to the 0.12.0 milestone May 28, 2020
@fbricon fbricon added the build label May 28, 2020
@xorye
Copy link

xorye commented May 29, 2020

Works in both the current VS Code release and the latest Insiders (which uses --inspect)

@fbricon fbricon merged commit e01d3e0 into redhat-developer:master May 29, 2020
@fbricon fbricon deleted the make-debugging-great-again branch May 29, 2020 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants