Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xml.format.preserveAttributeLineBreaks setting #271

Merged
merged 1 commit into from
Jun 10, 2020
Merged

Add xml.format.preserveAttributeLineBreaks setting #271

merged 1 commit into from
Jun 10, 2020

Conversation

xorye
Copy link

@xorye xorye commented Jun 9, 2020

Signed-off-by: David Kwon dakwon@redhat.com

Signed-off-by: David Kwon <dakwon@redhat.com>
@@ -182,7 +188,7 @@
"Ignore quote style formatting."
],
"default": "ignore",
"markdownDescription": "Enforce `preferred` quote style (set by `xml.preferences.quoteStyle`) or `ignore` quote style when formatting. Default is `ignore`",
"markdownDescription": "Enforce `preferred` quote style (set by `#xml.preferences.quoteStyle#`) or `ignore` quote style when formatting. Default is `ignore`",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the #s?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the #s creates a link:
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice @xorye :)

@fbricon fbricon merged commit 457d2d5 into redhat-developer:master Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants