Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new formatting setting xml.format.splitAttributesIndentSize #386

Merged
merged 1 commit into from
Dec 23, 2020

Conversation

datho7561
Copy link
Contributor

Add a new setting which controls the level of indentation of attributes
with respect to their parent element when xml.format.splitAttributes
is set to true.

Based off of a comment by Cong Wang (@I322871) on the vscode-xml Gitter

Signed-off-by: David Thompson davthomp@redhat.com

@datho7561
Copy link
Contributor Author

Please see the server side changes: eclipse/lemminx#952

docs/Formatting.md Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@datho7561 datho7561 changed the title Add new formatting setting xml.format.numberOfIndentsForSplitAttributes Add new formatting setting xml.format.splitAttributesIndentSize Dec 23, 2020
@datho7561
Copy link
Contributor Author

datho7561 commented Dec 23, 2020

  • Rename commit

package.json Outdated Show resolved Hide resolved
@angelozerr
Copy link
Contributor

@datho7561 the new xml.format.splitAttributesIndentSize must be added in the README too

package-lock.json Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Add a new setting which controls the level of indentation of attributes
with respect to their parent element when `xml.format.splitAttributes`
is set to `true`.

Based off of a comment by Cong Wang (@I322871) on the vscode-xml Gitter

Signed-off-by: David Thompson <davthomp@redhat.com>
@angelozerr angelozerr merged commit f64634c into redhat-developer:master Dec 23, 2020
@angelozerr
Copy link
Contributor

Thanks @datho7561 !

@angelozerr angelozerr added this to the 0.15.0 milestone Dec 23, 2020
@datho7561 datho7561 deleted the only-one-tab branch January 18, 2021 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants