Rename telemetry events #453

datho7561 · 2021-04-14T17:06:47Z

Use . consistently as the separator in event names. Prefix event names with xml.. Group the binary download events into xml_binary_download. Add a parameter status that indicates if the download succeeded, failed or was aborted.

Signed-off-by: David Thompson davthomp@redhat.com

datho7561 · 2021-04-14T17:06:55Z

@fbricon

src/server/binary/binaryServerStarter.ts

fbricon · 2021-04-14T17:15:15Z

Please use . instead of _ as separator

src/telemetry.ts

src/server/binary/binaryServerStarter.ts

datho7561 · 2021-04-14T17:34:39Z

Please use . instead of _ as separator

I thought that there was some issue with using .?

fbricon · 2021-04-14T17:43:13Z

I thought that there was some issue with using .?

No the issue is with :. Using . is consistent with the rest of our existing events

src/server/binary/binaryServerStarter.ts

datho7561 · 2021-04-14T18:58:26Z

No the issue is with :. Using . is consistent with the rest of our existing events

Okay. LemMinX's reporting is also inconsistent then (lemminx uses server_start, server_stop). I'll take a look at what needs to be done to change it in LemMinX as well.

Use `.` consistently as the separator in event names. Prefix event names with `xml.`. Group the binary download events into `xml_binary_download`. Add a parameter `status` that indicates if the download succeeded, failed or was aborted. Signed-off-by: David Thompson <davthomp@redhat.com>

datho7561 · 2021-04-14T19:32:25Z

eclipse/lemminx#1017

datho7561 commented Apr 14, 2021

View reviewed changes

src/server/binary/binaryServerStarter.ts Outdated Show resolved Hide resolved

src/server/binary/binaryServerStarter.ts Outdated Show resolved Hide resolved

datho7561 force-pushed the change-download-event-name branch from 61805c6 to 8fa73cb Compare April 14, 2021 17:14